fix: sounds not playing if using app default and send to overlay #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zunderscore
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix an issue where Firebot would fail to play sounds if the effect has App Default selected, which is set to Send To Overlay.
Applicable Issues
Discord Issue
Testing
Ensured that App Default + Send To Overlay now functions as expected
Ensured App Default + System Default still plays audio as expected
Ensured App Default + Audio Device still plays audio to the specified device as expected
Ensured System Default and Audio Device play audio as expected
Ensured overlay (default and non-default instances) play audio as expected