fix: name UI translation files by BCP-47 lang tag#746
Merged
Conversation
Starlight keys UI translations (sidebar labels and interface strings) by each locale's `lang` tag, not by its folder key. The pt/es/tr files were named pt.json/es.json/tr.json while their lang tags are pt-PT/ es-ES/tr-TR, so Starlight failed the lookup and fell back to English. de/da/fr worked only because their folder key happens to equal their tag. - Rename i18n files to match the lang tag: pt.json -> pt-PT.json, es.json -> es-ES.json, tr.json -> tr-TR.json - Update imports and key the sidebar `translations` map by lang tag in src/utils/i18n.ts - Give the i18n.json entry in crowdin.yml its own languages_mapping so future syncs export the BCP-47 filenames (tr -> tr-TR, etc.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starlight keys UI translations (sidebar labels and interface strings) by each locale's
langtag, not by its folder key. The pt/es/tr files were named pt.json/es.json/tr.json while their lang tags are pt-PT/ es-ES/tr-TR, so Starlight failed the lookup and fell back to English. de/da/fr worked only because their folder key happens to equal their tag.translationsmap by lang tag in src/utils/i18n.ts