feat: #75 Implement event fund withdrawal for organizers - #144
Merged
manoahLinks merged 2 commits intoMar 28, 2026
Merged
Conversation
…s-live#75) Add withdraw_funds(event_id) to the event_manager contract so organizers can collect accumulated ticket-sale revenue after an event concludes. Guards enforced: - Only callable by the event organizer (require_auth) - Only after event end_date has passed (EventNotEnded) - Only if the event was not cancelled (EventAlreadyCanceled) - Prevents double withdrawal via a persistent FundsWithdrawn flag Funds are now escrowed in the contract during purchase_ticket / purchase_tickets (tracked in EventBalance per event) and released to the organizer wallet via withdraw_funds. claim_refund deducts from the escrowed balance when a cancelled event is refunded. New additions: - DataKey::EventBalance(u32) — escrowed balance per event - DataKey::FundsWithdrawn(u32) — double-withdrawal guard - Error::EventNotEnded (19), Error::FundsAlreadyWithdrawn (20) - withdraw_funds public function with full guard logic - 8 new tests covering all edge cases Also resolves pre-existing merge-conflict artifacts in lib.rs and test.rs (duplicate function definitions, conflicting error enum values) that prevented the contract from compiling.
|
@jayteemoney Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withdraw_funds(event_id)to theevent_managerSoroban contract so organizers can collect accumulated ticket-sale revenue after an event concludespurchase_ticket/purchase_ticketsare now held by the contract (EventBalanceper event) rather than sent directly to the organizer, and released viawithdraw_fundsclaim_refunddeducts from the escrowed balance so refunds on cancelled events remain functionalRequirements fulfilled
withdraw_funds(event_id)in event_managerevent.organizer.require_auth()Error::EventNotEndedguardError::EventAlreadyCanceledguardfunds_withdrawnevent publishedDataKey::FundsWithdrawnpersistent flagNew storage keys
DataKey::EventBalance(u32)— escrowed ticket-sale balance per eventDataKey::FundsWithdrawn(u32)— double-withdrawal guard flagNew error variants
Error::EventNotEnded = 19Error::FundsAlreadyWithdrawn = 20Test results
Closes #75