Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented May 24, 2024

from the 1.22 release notes:

The syscall package has been frozen since Go 1.4 and was marked as deprecated in Go 1.11 [...] However, some non-deprecated functionality requires use of the syscall package [...] To avoid unnecessary complaints[...] no longer marked as deprecated. The package remains frozen to most new functionality, and new code remains encouraged to use golang.org/x/sys/unix or golang.org/x/sys/windows where possible.

@mmetc mmetc added this to the 1.6.3 milestone May 24, 2024
@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

❌ Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.94%. Comparing base (19d79a8) to head (d2bbb04).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/fsutil/getfstype_windows.go 0.00% 5 Missing ⚠️
.../acquisition/modules/wineventlog/config_windows.go 50.00% 2 Missing ⚠️
cmd/crowdsec/win_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3032      +/-   ##
==========================================
+ Coverage   62.92%   62.94%   +0.01%     
==========================================
  Files         467      467              
  Lines       33288    33298      +10     
==========================================
+ Hits        20948    20959      +11     
- Misses      10220    10221       +1     
+ Partials     2120     2118       -2     
Flag Coverage Δ
bats 46.14% <50.00%> (-0.01%) ⬇️
unit-linux 35.73% <100.00%> (-0.02%) ⬇️
unit-windows 25.06% <38.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as ready for review May 30, 2024 12:32
@mmetc mmetc force-pushed the syscall branch 2 times, most recently from 0a2021f to b71e296 Compare May 31, 2024 18:29
@mmetc mmetc removed this from the 1.6.3 milestone Jun 21, 2024
@mmetc mmetc added this to the 1.6.4 milestone Jul 24, 2024
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Oct 30, 2024
@mmetc mmetc removed this from the 1.6.5 milestone Dec 20, 2024
from the 1.22 release notes:

The syscall package has been frozen since Go 1.4 and was marked as deprecated in Go 1.11 [...]
However, some non-deprecated functionality requires use of the syscall package [...]
To avoid unnecessary complaints[...] no longer marked as deprecated.
The package remains frozen to most new functionality, and new code remains encouraged
to use golang.org/x/sys/unix or golang.org/x/sys/windows where possible.
@mmetc mmetc added this to the 1.7.5 milestone Dec 19, 2025
@mmetc mmetc requested a review from blotus December 19, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants