refact pkg/leakybucket: simpler timer logic, remove defer call from loop

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (14a1725) to head (8dd9f5b).

Files with missing lines	Patch %	Lines
pkg/leakybucket/bucket.go	52.94%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3627      +/-   ##
==========================================
- Coverage   61.46%   60.75%   -0.71%     
==========================================
  Files         360      372      +12     
  Lines       39939    40812     +873     
==========================================
+ Hits        24547    24797     +250     
- Misses      13391    13964     +573     
- Partials     2001     2051      +50     

Flag	Coverage Δ
bats	44.70% <47.05%> (-0.02%)	⬇️
unit-linux	34.25% <52.94%> (-0.16%)	⬇️
unit-windows	24.17% <52.94%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.