Skip to content

refact: plugin config parsing #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refact: plugin config parsing #3640

wants to merge 1 commit into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2025

No description provided.

@mmetc mmetc added this to the Next release milestone May 17, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.83%. Comparing base (d7d7e67) to head (a445d84).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clinotifications/notifications.go 33.33% 3 Missing and 1 partial ⚠️
pkg/csplugin/broker.go 86.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3640      +/-   ##
==========================================
- Coverage   60.83%   60.83%   -0.01%     
==========================================
  Files         372      372              
  Lines       40935    40944       +9     
==========================================
+ Hits        24903    24908       +5     
- Misses      13985    13986       +1     
- Partials     2047     2050       +3     
Flag Coverage Δ
bats 44.59% <77.77%> (-0.02%) ⬇️
unit-linux 34.38% <52.77%> (-0.01%) ⬇️
unit-windows 24.33% <52.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc changed the title refact: plugin config refact: plugin config parsing May 22, 2025
@mmetc mmetc marked this pull request as draft May 22, 2025 11:03
@mmetc mmetc marked this pull request as ready for review June 6, 2025 13:02
@mmetc mmetc requested a review from blotus June 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant