Skip to content

cscli capi register: no error if online_api_credentials.yaml does not exist #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 21, 2025

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the Next release milestone May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (818974e) to head (b55a7fc).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clicapi/capi.go 76.92% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clisupport/support.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3645      +/-   ##
==========================================
+ Coverage   60.77%   60.82%   +0.05%     
==========================================
  Files         372      372              
  Lines       40917    40929      +12     
==========================================
+ Hits        24869    24897      +28     
+ Misses      13991    13979      -12     
+ Partials     2057     2053       -4     
Flag Coverage Δ
bats 44.58% <82.60%> (+0.06%) ⬆️
unit-linux 34.38% <8.69%> (-0.02%) ⬇️
unit-windows 24.31% <8.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as draft May 21, 2025 14:23
@mmetc mmetc force-pushed the register-missing-creds branch from 995ada9 to 6352dcf Compare May 22, 2025 07:19
@mmetc mmetc marked this pull request as ready for review May 23, 2025 07:48
@mmetc mmetc force-pushed the register-missing-creds branch from 6352dcf to b55a7fc Compare May 23, 2025 07:48
@mmetc mmetc requested a review from sabban June 11, 2025 11:29
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants