refact pkg/cwhub

[mmetc]

method extraction, clearer logic etc.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: Patch coverage is 77.65957% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (e9aa155) to head (b806ff4).

Files with missing lines	Patch %	Lines
pkg/cwhub/safepath.go	60.86%	6 Missing and 3 partials ⚠️
pkg/cwhub/fetch.go	76.47%	2 Missing and 2 partials ⚠️
pkg/cwhub/sync.go	87.50%	3 Missing and 1 partial ⚠️
pkg/cwhub/relativepath.go	50.00%	3 Missing ⚠️
pkg/cwhub/download.go	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
+ Coverage   60.70%   60.73%   +0.03%     
==========================================
  Files         372      373       +1     
  Lines       41019    41043      +24     
==========================================
+ Hits        24899    24926      +27     
+ Misses      14070    14068       -2     
+ Partials     2050     2049       -1     

Flag	Coverage Δ
bats	44.43% <64.89%> (-0.03%)	⬇️
unit-linux	34.37% <39.36%> (+0.01%)	⬆️
unit-windows	24.31% <39.36%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sabban]

lgtm