Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 16, 2025

No description provided.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.92%. Comparing base (b1f8e05) to head (f0395c9).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/config.go 46.66% 4 Missing and 4 partials ⚠️
pkg/acquisition/acquisition.go 68.75% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4148      +/-   ##
==========================================
- Coverage   62.94%   62.92%   -0.03%     
==========================================
  Files         467      467              
  Lines       33288    33300      +12     
==========================================
  Hits        20954    20954              
- Misses      10218    10225       +7     
- Partials     2116     2121       +5     
Flag Coverage Δ
bats 46.07% <72.34%> (-0.08%) ⬇️
unit-linux 35.75% <14.89%> (-0.02%) ⬇️
unit-windows 25.04% <12.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as ready for review December 16, 2025 09:11
@mmetc mmetc requested a review from blotus December 16, 2025 09:30
@mmetc mmetc removed the request for review from blotus December 16, 2025 22:09
@mmetc mmetc changed the title appsec: inject hub dependency, avoid global appsec: inject dependencies, avoid globals Dec 16, 2025
@mmetc mmetc marked this pull request as draft December 16, 2025 22:27
@mmetc mmetc force-pushed the appsec-hub branch 2 times, most recently from 9608107 to deba4aa Compare December 19, 2025 10:33
@mmetc mmetc marked this pull request as ready for review December 19, 2025 13:41
@mmetc mmetc requested a review from blotus December 19, 2025 13:58
@mmetc mmetc merged commit 113a6da into master Dec 19, 2025
16 checks passed
@mmetc mmetc deleted the appsec-hub branch December 19, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants