docker: add default healthcheck to container images

[LaurenceJJones]

Adds HEALTHCHECK instruction using cscli lapi status to verify the local API is responding.

Related to #4160
Related to #3603

[github-actions]

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind refactoring
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.94%. Comparing base (5b1f5eb) to head (324717d).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4161   +/-   ##
=======================================
  Coverage   62.94%   62.94%           
=======================================
  Files         467      467           
  Lines       33298    33298           
=======================================
  Hits        20961    20961           
- Misses      10218    10220    +2     
+ Partials     2119     2117    -2     

Flag	Coverage Δ
bats	46.11% <ø> (-0.05%)	⬇️
unit-linux	35.77% <ø> (+0.02%)	⬆️
unit-windows	25.05% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LaurenceJJones]

Just thought if LAPI only container then what? Need to test

[mmetc]

what if it's a log processor only? it will test the health of the LAPI container, not the LP.

[LaurenceJJones]

what if it's a log processor only? it will test the health of the LAPI container, not the LP.

Well it will test the health between lp and lapi so technically not bad, but we don't really have a way to know I'm healthy for lp only.

[mmetc]

we don't really have a way to know I'm healthy for lp only.

maybe metrics? log processors still expose them when lapi is disabled, and they shouldn't kick in unless LP is healthy. I'm not saying we should do that, just that they are available.