Add version checking and force upgrade functionality to upgrade.sh#80
Draft
LaurenceJJones wants to merge 1 commit into
Draft
Add version checking and force upgrade functionality to upgrade.sh#80LaurenceJJones wants to merge 1 commit into
LaurenceJJones wants to merge 1 commit into
Conversation
Features added: - Version comparison between current and new binaries - Smart upgrade detection (skips if versions are same or new version is older) - Force upgrade option (--force/-f) to override version checks - Help option (--help/-h) with usage information - User confirmation prompt for interactive upgrades - Informative messages about version differences This addresses user requests for: - Checking if upgrade is actually needed before proceeding - Ability to force upgrade when building from source - Better user experience with clear feedback about version changes Functions added to _bouncer.sh: - get_bouncer_version(): Extract version from binary --version output - version_compare(): Compare semantic versions (major.minor.patch) - check_upgrade_needed(): Main logic for upgrade decision making
sabban
reviewed
Oct 6, 2025
sabban
left a comment
Contributor
There was a problem hiding this comment.
I would rather keep this file as much as the same as the other bouncer.
I am not against it, but if changed here maybe it's worth changing it for every bouncer.
Contributor
|
A few things
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #77
Features added:
- Version comparison between current and new binaries
- Smart upgrade detection (skips if versions are same or new version is older)
- Force upgrade option (--force/-f) to override version checks
- Help option (--help/-h) with usage information
- User confirmation prompt for interactive upgrades
- Informative messages about version differences
This addresses user requests for:
- Checking if upgrade is actually needed before proceeding
- Ability to force upgrade when building from source
- Better user experience with clear feedback about version changes
Functions added to _bouncer.sh:
- get_bouncer_version(): Extract version from binary --version output
- version_compare(): Compare semantic versions (major.minor.patch)
- check_upgrade_needed(): Main logic for upgrade decision making