add nginx controlled variable #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Refactored ~split~ function to use ~local~ for variable declaration. + Enhanced ~has_value~ function by removing unused variable ~index~. + Moved ~valid_params~, ~valid_int_params~, ~valid_bouncing_on_type_values~, and ~valid_truefalse_values~ to a higher scope for better reusability. + Improved ~EXCLUDE_LOCATION~ handling
…default values Added support for loading local configuration overrides in ~csmod.init~. Enhanced ~config.loadConfig~ to optionally load default values for missing parameters. Refactored and cleaned up redundant code in ~config.lua~.
Ensure that the main configuration file is loaded with strict validation and the local configuration file is loaded without strict validation.
Introduce a new test script ~t/15_live_ban_and_config.t~ to validate live ban and configuration functionality. The test includes: + Initialization of ~LWP::UserAgent~ for HTTP requests. + Verification of HTTP responses and logging initialization status.
|
…tion checks Refactored the logic for determining bouncer and appsec enablement into dedicated helper functions (`is_bouncer_enabled` and `is_appsec_enabled`). Updated the `Allow` function to use these helpers for improved readability and maintainability.
Refactored the logic for determining the enabled state of bouncer and appsec configurations. Introduced a new function `is_always_send_to_appsec` to streamline checks for always sending to appsec. Updated the `Allow` function to use the new logic for better readability and maintainability
Reordered conditions in ~is_appsec_enabled~ to ensure proper evaluation. Fixed parentheses in ~csmod.Allow~ to correctly group logical operations.
The indentation in the loop parsing the `EXCLUDE_LOCATION` key was inconsistent. This change ensures proper alignment for better readability and maintainability.
blotus
approved these changes
May 26, 2025
buixor
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add nginx controlled variable and corresponding test