Draft
Refactor CUDA backend: replace CudaInternal singleton with HostSharedPtr default_instance#28
Conversation
…nstance Move initialization from CudaInternal::initialize() to constructor, and finalization from CudaInternal::finalize() to destructor. Replace CudaInternal::singleton() with static HostSharedPtr<CudaInternal> default_instance, following the HIP backend pattern from PR 7646. Co-authored-by: crtrott <9490481+crtrott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor CudaInternal class to remove singleton pattern
Refactor CUDA backend: replace CudaInternal singleton with HostSharedPtr default_instance
Feb 10, 2026
crtrott
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
CudaInternalto match the HIP backend pattern established in kokkos#7646. Replaces the static singleton withHostSharedPtr-managed lifetime, moves init/finalize logic into constructor/destructor.Changes
CudaInternalclass (Kokkos_Cuda_Instance.hpp):static CudaInternal& singleton()→static HostSharedPtr<CudaInternal> default_instanceCudaInternal(cudaStream_t stream)(initialization in ctor)finalize()cleanup logic →~CudaInternal()(with fence before destruction)initialize(),finalize(),is_initialized(),was_initialized,was_finalized= deleteCudaexecution space (Kokkos_Cuda_Instance.cpp):impl_initialize(): createsdefault_instanceviaHostSharedPtr(new CudaInternal(stream), deleter)impl_finalize():default_instance = nullptrCuda(): copiesdefault_instance(was: non-owning ptr to singleton)Cuda(stream, manage_stream):new CudaInternal(stream)with conditional stream-destroying deleterKokkos_CudaSpace.cpp:CudaInternal::singleton().→CudaInternal::default_instance->Pattern (mirrors HIP)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.