Rename LOG_LEVEL so as to not conflict with downstream applications. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broamski
approved these changes
Mar 9, 2021
somethingnew2-0
approved these changes
Mar 9, 2021
Contributor
|
Do we care about backwards compatibility or is this PR to be intentionally backwards incompatible? |
Collaborator
Yes, I think we should save this for version 2.0. Agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
LOG_LEVEL,LOG_LEVEL_FIELD_NAME, andLOG_STRUCTUREDto all be prefixed withDAYTONA_, so as to not conflict with applications executed by Daytona when used as anENTRYPOINTin a containerized environment. This also updates README.md, and has some minor fixes to.gitignore.