Flow control for async message consumers #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping node engine to >= v10.0.0 since existing test cases fail at lower versions. Usage: see bag.test.js
janpaul123
reviewed
Jun 17, 2020
Contributor
janpaul123
left a comment
janpaul123
left a comment
There was a problem hiding this comment.
This makes a lot of sense to me. Thanks also for the test and the other cleanup. @brianc or @MatthewSteel can I get another review from one of you just to be sure?
Btw, also feel free to join our Slack if you want to chat more! cruise-automation/webviz#461
This union type adds complexity and isn't necessary. Also add the value, which is parsed for constants but doesn't appear in the type defintion. This will allow us to match the typedef in Webviz. Test plan: only flow type change
Bumping node engine to >= v10.0.0 since existing test cases fail at lower versions. Usage: see bag.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all thanks for providing rosbag.js it really made my day ☀️
I'm dealing with rosbag files that exceed my heap space and want to perform async operations on the messages.
Since (IMHU) calling
bag.readMessagesprovides no means to slow down the producer I have to choose between dropping messages or running out of heap.As a resolve I added flow control via
bag.iterateMessages. It does almost exactly the same thing asbag.readMessagesbut it acts as async generator. That means the consumer can (if desired) halt and resume the reading process.In order to avoid code redundancies and minimise code changes, I rewired
readMessagesto invokeiterateMessagesmaintaining its original behavior.Documentation and one additional test case is included in this PR.
If I overlooked existing functionality that already provides flow control, please let me know, so that I can use that instead.
I also bumped the node engine version to 10+ because the existing test cases failed at lower versions.
Regards, Marc