Skip to content

Review supported Python versions and platforms#2

Closed
crusaderky wants to merge 4 commits into
avx512pffrom
ci-refresh
Closed

Review supported Python versions and platforms#2
crusaderky wants to merge 4 commits into
avx512pffrom
ci-refresh

Conversation

@crusaderky

@crusaderky crusaderky commented Nov 25, 2025

Copy link
Copy Markdown
Owner
  • Align supported Python versions everywhere to 3.10 ~ 3.14, as per the wheels produced for release 1.3.3. This is also in line with the latest release of spacy.
  • Run tests on all versions of Python
  • Run tests on Linux ARM, MacOSX Intel, and MacOSX ARM

This PR is on top of explosion#129.
CI run can be seen at explosion#130.

Comment on lines 80 to 96
- name: Build wheel (Mac)
if: startsWith(matrix.os, 'macos')
run: |
python -m build --wheel

- name: Build wheel (Linux / clang)
if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.6'
run: |
clang --version
CC=clang python -m build --wheel
python -m build --wheel

- name: Build wheel (Linux / gcc-9)
if: startsWith(matrix.os, 'ubuntu') && (matrix.python_version == '3.7' || matrix.python_version == '3.8')
- name: Build wheel (Linux / gcc)
if: startsWith(matrix.os, 'ubuntu') && matrix.cc == ''
run: |
sudo apt update
sudo apt install gcc-9
gcc-9 --version
CC=gcc-9 python -m build --wheel
gcc --version
python -m build --wheel

- name: Build wheel (Linux / gcc-10)
if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.9'
run: |
sudo apt update
sudo apt install gcc-10
gcc-10 --version
CC=gcc-10 python -m build --wheel
- name: Build wheel (Linux / clang-13)
if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.10'
- name: Build wheel (Linux / clang)
if: startsWith(matrix.os, 'ubuntu') && matrix.cc == 'clang'
run: |
clang --version
CC=clang python -m build --wheel

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is slightly more verbose than it could be, for the sake of readibility.

Comment on lines -55 to -66
set "PATH=C:\\Program Files\\LLVM\\bin;%PATH%"
set "AR=llvm-ar"
set "AS=llvm-as"
set "CC=clang"
set "RANLIB=echo"
call "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" amd64
clang --version
python -m build --wheel
shell: cmd
- name: Build wheel (Windows)
if: startsWith(matrix.os, 'windows')
run: |

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was duplicated

Comment thread azure-pipelines.yml
Python310Linux:
imageName: 'ubuntu-22.04'
python.version: '3.9'
python.version: '3.10'

@crusaderky crusaderky Nov 25, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Azure jobs seem redundant with gh actions. Removing them altogether is out of scope for this PR though.

Comment thread requirements.txt
# Test requirements
numpy>=1.15.0; python_version < "3.9"
numpy>=1.19.0; python_version >= "3.9"
numpy>=1.21.2

@crusaderky crusaderky Nov 25, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the oldest numpy that supports python 3.10
Follow-up:

Remove obsolete AVX512 compilation flags
@crusaderky
crusaderky deleted the branch avx512pf November 25, 2025 16:11
@crusaderky crusaderky closed this Nov 25, 2025
@crusaderky crusaderky reopened this Nov 25, 2025

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI didn't fire here. Otherwise looks good but I'd like to look over the CI logs.

Comment thread .github/workflows/tests.yml Outdated
@crusaderky

Copy link
Copy Markdown
Owner Author

It looks like CI didn't fire here. Otherwise looks good but I'd like to look over the CI logs.

CI didn't fire because it needs #1 to fire. Successful CI run is visible at explosion#130.

@crusaderky

Copy link
Copy Markdown
Owner Author

Merged explosion#130

@crusaderky crusaderky closed this Nov 26, 2025
@crusaderky
crusaderky deleted the ci-refresh branch November 26, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants