test(samples): add liveness/readiness probes to sample apps #1098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Related to cryostatio/cryostat-agent#634
Description of the change:
Adds liveness and readiness probes to two of the sample app definitions. These are the two that represent the common cases - an Agent-less application that is discovered by Endpoints (EndpointSlice) and uses JMX, and an autoconfig-injected Agent.
Motivation for the change:
Make these two sample app cases more representative of real production workloads which should be expected to use liveness and readiness probes.
How to manually test:
make sample_app
andmake sample_app_agent_injected
as usual, ensuring that discovery for both works as usual and that Kubernetes reports both as alive and ready to accept traffic. Check the injected Agent's logs in the application Pod and observe that initially, the Agent fails to resolve its own callback URL (hostname), but once the pod probes succeed then the Agent becomes able to resolve itself and proceeds with Cryostat registration.