Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 21, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#1171
Depends on cryostatio/cryostat#1171

Description of the change:

Applies the same filename query parameter handling so that the backend sets the Content-Disposition header accordingly.

More importantly, updates the filename query parameter handling so not always hardcode the ? query string separator, and to only infix it if needed. Otherwise, when the Cryostat UI is running within an OpenShift Console Plugin context, the query string construction may conflict with the console proxy instance selector query string construction.


This is an automatic backport of pull request #1937 done by [Mergify](https://mergify.com).

…instance selector query param (#1937)

(cherry picked from commit baf0125)
@github-actions
Copy link

This PR/issue depends on:

@github-actions
Copy link

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores andrewazores merged commit 79b4aa9 into cryostat-v4.1 Nov 21, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants