Skip to content

Conversation

@Josh-Matsuoka
Copy link
Contributor

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1869

Description of the change:

Wraps the text for the diagnostics buttons in a Truncate component so they will get truncated if the screen gets resized to prevent overflowing the component and help wth the issues found in the linked issue.

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@Josh-Matsuoka
Copy link
Contributor Author

doing a bit more testing it still overflows the component for some very small/zoomed in configurations, It seems like it's related to setting up the page as a grid with the current proportions, if I change the numbers a bit and force the diagnostics actions on to their own 'row' the resize issues don't seem to happen as much, the downside being now the page looks pretty odd.

@Josh-Matsuoka
Copy link
Contributor Author

Reworked it to reuse the diagnostics card instead, the buttons no longer overflow the component on any resize I tried

@andrewazores
Copy link
Member

andrewazores commented Dec 15, 2025

Needs some formatting attention ("prettier" check).

Directly using the Dashboard card has a few minor issues to be worked out:

  1. There's some additional padding around the card content, which doesn't feel necessary when the card is placed within an already mostly empty container.
  2. The card has the right edge resize handle component, which can't actually be used when the card is in this context.
image

I think a bit of refactoring to extract the card content as a component and then use that here, rather than the entire card, would solve both issues. Or, maybe that work has already been done (I didn't check) and this can be achieved by just passing some props to the card component - the MBean Metrics card in the same view has props like isDraggable={false} isResizable={false} for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Capture Diagnostics card for invoking actions should better handle different screen sizes

2 participants