Skip to content

feat(rules): allow patching of all rule fields #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat-web#1581

Description of the change:

Allows more Automated Rule fields to be updated by the existing PATCH endpoint. Rule names cannot be modified this way but anything else can be.

Motivation for the change:

Required for upcoming frontend feature to allow editing existing Rules or duplicating Rules.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 4/22/2025, 4:42:58 PM. View Actions Run.

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/14604256546

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 4/22/2025, 4:48:45 PM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/14604352695

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/14604352695

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 4/23/2025, 3:05:36 PM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/14626078179

@andrewazores andrewazores marked this pull request as ready for review April 23, 2025 20:04
@andrewazores andrewazores requested a review from a team April 23, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant