Skip to content

test(s3): simplify s3 configurations #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat-helm#247

Description of the change:

While working on the linked Helm issue and using the smoketest S3 configurations as references, I noticed that things could be cleaned up.

There is no need to explicitly set QUARKUS_S3_AWS_CREDENTIALS_TYPE=static, since the default value is default and uses a strategy of checking various provider sources, including the static provider. The static provider looks for a few options such as a home directory config file, as well as the already existing AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables.

Also, cloudserver was missing a healthcheck definition which caused it to fail to start.

How to manually test:

  1. Check out PR
  2. ./smoketest.bash -s {provider}, where provider is one of seaweed, localstack, cloudserver, or minio (ie. any of the s3-*.yml compose files)
  3. Wait for readiness, then open UI. Verify archive functionality is working as expected.

@mergify mergify bot added the safe-to-test label May 16, 2025
@andrewazores andrewazores requested a review from a team May 16, 2025 15:05
@andrewazores andrewazores force-pushed the s3-smoketest-config branch from f1af2a0 to 597568e Compare May 16, 2025 15:05
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 5/16/2025, 11:05:57 AM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/15071535929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant