Gp/fiber 050

[gpBlockchain]

No description provided.

[Copilot]

Copilot reviewed 92 out of 99 changed files in this pull request and generated no comments.

Files not reviewed (7)

• Makefile: Language not supported
• prepare.sh: Language not supported
• source/template/fiber/config.yml.j2: Language not supported
• source/template/fiber/dev_config.yml.j2: Language not supported
• source/template/fiber/dev_config_2.yml.j2: Language not supported
• source/template/fiber/main_config.yml.j2: Language not supported
• source/template/fiber/testnet_config_2.yml.j2: Language not supported

Comments suppressed due to low confidence (7)

test_cases/fiber/devnet/accept_channel/test_tlc_expiry_delta.py:7

• [nitpick] The commented-out test method 'test_tlc_expiry_delta' suggests incomplete test coverage; consider either implementing the test or removing the placeholder to keep the test suite clean.

# def test_tlc_expiry_delta(self):

framework/test_node.py:284

• [nitpick] Using 'grep LISTEN' to filter processes may inadvertently terminate unintended processes if multiple processes match; consider additional filtering to target the correct process.

run_command(f"kill $(lsof -i:{port} | grep LISTEN | awk '{{print $2}}')", check_exit_code=False)

framework/basic_fiber.py:488

• [nitpick] The introduced fee tolerance range may mask discrepancies in fee calculation; consider adding logging or tighter constraints to improve clarity in case of assertion failures.

assert int(pool_tx_detail_info["score_sortkey"]["fee"], 16) * 1000 / int(pool_tx_detail_info["score_sortkey"]["weight"], 16) <= fee_rate * (1 + up_and_down_rate)

download_fiber.py:45

• [nitpick] Verify that the updated tarball filename 'x86_64-darwin-portable.tar.gz' correctly corresponds to the intended release artifacts and matches the naming conventions used elsewhere in the project.

"version}-x86_64-darwin-portable.tar.gz",

download_ckb_light_client.py:39

• [nitpick] Ensure that the modified tarball filename for Darwin in the light client download script matches the expected artifact naming conventions across the project.

"version}-x86_64-darwin-portable.tar.gz",

.github/workflows/fiber.yml:332

• [nitpick] Consider reviewing the consistency of artifact naming conventions across workflow jobs to avoid confusion, ensuring that all names clearly indicate the corresponding job or report type.

name: jfoa-watch_tower-reports-${{ runner.os }}

framework/rpc.py:222

• [nitpick] Extending the retry loop to 200 iterations may lead to longer delays in error handling; consider making this value configurable or verifying that the extended loop is necessary for the expected operation.

for i in range(200):