Problem: recent bug fixes are not included#1746
Draft
mmsqe wants to merge 7 commits intocrypto-org-chain:release/v1.3.xfrom
Draft
Problem: recent bug fixes are not included#1746mmsqe wants to merge 7 commits intocrypto-org-chain:release/v1.3.xfrom
mmsqe wants to merge 7 commits intocrypto-org-chain:release/v1.3.xfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.3.x #1746 +/- ##
==================================================
+ Coverage 36.29% 36.32% +0.03%
==================================================
Files 146 146
Lines 12623 12629 +6
==================================================
+ Hits 4581 4588 +7
+ Misses 7587 7586 -1
Partials 455 455
|
mmsqe
changed the title
mmsqe
commented
Feb 17, 2025
| time.sleep(3) | ||
| print(cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb", dry_run=True)) | ||
| cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb") | ||
| print(cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb", dry_run=True)) |
Contributor
Author
There was a problem hiding this comment.
@yihuang have fix data: feemarket after fixdata
…#1745) * Problem: miss diff info when assert from test utils * align rootdir * fix upload
crypto-org-chain#1747) * Problem: need batch initialization run fixdata with dry-run * mod tidy * skip flush
…rypto-org-chain#1748) * Problem: need run fixdata multiple times when no timestamp checking query with GetCFWithTS to compare both timestamp and key * cleanup * doc
…ksdb (crypto-org-chain#1751) * Problem: no deallocate read options * doc * sync deps
mmsqe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)