Problem: sdk 53 is not integrated #1799

mmsqe · 2025-05-02T03:11:47Z

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

coderabbitai · 2025-05-02T03:11:53Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-05-02T03:15:40Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	golang/golang.org/x/crypto@v0.37.0
	golang/github.com/mmsqe/ethermint@v0.6.5-0.20250502043624-645d260bdeb2
	golang/google.golang.org/grpc@v1.71.1
	golang/google.golang.org/protobuf@v1.36.6
	golang/github.com/mmsqe/cosmos-sdk@v0.46.0-beta2.0.20250502025930-9ee27ce5d100
	golang/cosmossdk.io/api@v0.7.6 ⏵ v0.9.0	⁺¹
	golang/google.golang.org/genproto/googleapis/api@v0.0.0-20250324211829-b45e905df463
	golang/github.com/hashicorp/go-metrics@v0.5.4
	golang/github.com/spf13/cobra@v1.9.1
	golang/github.com/spf13/pflag@v1.0.6
	golang/github.com/spf13/viper@v1.20.1
	golang/github.com/mmsqe/cosmos-sdk/store@v0.0.0-20250502025930-9ee27ce5d100
	golang/cosmossdk.io/x/upgrade@v0.1.4 ⏵ v0.2.0-rc.2	⁺¹
	golang/cosmossdk.io/client/v2@v2.0.0-beta.5 ⏵ v2.0.0-beta.5.0.20241121152743-3dad36d9a29e	⁺¹
	golang/cosmossdk.io/errors@v1.0.2
	golang/github.com/spf13/cast@v1.7.1
	golang/cosmossdk.io/x/evidence@v0.1.1 ⏵ v0.2.0-rc.2	⁺¹
	golang/cosmossdk.io/x/feegrant@v0.1.1 ⏵ v0.2.0-rc.2
	golang/github.com/mmsqe/cosmos-sdk/core@v0.0.0-20250502025930-9ee27ce5d100
	golang/cosmossdk.io/tools/confix@v0.1.2 ⏵ v0.2.0-rc.1	⁺¹
	golang/cosmossdk.io/math@v1.5.3
	golang/github.com/cosmos/cosmos-db@v1.0.3-0.20240408151834-e75f6e4b28d8 ⏵ v1.1.1
	golang/cosmossdk.io/log@v1.4.1 ⏵ v1.5.1

View full report

socket-security · 2025-05-02T03:15:42Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click for details)
Warn		`golang/github.com/gofiber/fiber/[email protected]` has a Critical CVE. CVE: GHSA-98j2-3j3p-fw2v Session Middleware Token Injection Vulnerability (CRITICAL) Affected versions: <= 2.52.4 Patched version: 2.52.5 From: `?` → `golang/github.com/gofiber/fiber/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore golang/github.com/gofiber/fiber/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

codecov · 2025-05-02T03:25:23Z

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.47%. Comparing base (a3c2f70) to head (b4264b5).
Report is 65 commits behind head on main.

Files with missing lines	Patch %	Lines
app/upgrades.go	25.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1799       +/-   ##
===========================================
+ Coverage   16.87%   35.47%   +18.59%     
===========================================
  Files          72      127       +55     
  Lines        6163    11903     +5740     
===========================================
+ Hits         1040     4222     +3182     
- Misses       5000     7258     +2258     
- Partials      123      423      +300

Files with missing lines	Coverage Δ
app/upgrades.go	`27.27% <25.00%> (+21.93%)`	⬆️

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

skip-check-header fix test

JayT106 · 2025-05-07T20:14:44Z

Hi, @mmsqe. You have the Cronos chain features integrated into the SDK v0.53 in your own repo, right? Would you be able to push it to https://github.com/crypto-org-chain/cosmos-sdk/tree/release/v0.53.x? What's your thoughts of the process to integrate with the SDK v0.53?

mmsqe force-pushed the bump_sdk branch 2 times, most recently from af43273 to f8ae2c5 Compare May 2, 2025 03:55

mmsqe added 2 commits May 2, 2025 13:58

Problem: sdk 53 is not integrated

7d04dcf

skip-check-header fix test

lint

ef869ab

mmsqe force-pushed the bump_sdk branch from d1d6c6e to ef869ab Compare May 2, 2025 05:59

lint

b4264b5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Problem: sdk 53 is not integrated #1799

Problem: sdk 53 is not integrated #1799

mmsqe commented May 2, 2025

Uh oh!

coderabbitai bot commented May 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

socket-security bot commented May 2, 2025 •

edited

Loading

Uh oh!

socket-security bot commented May 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 2, 2025 •

edited

Loading

Uh oh!

JayT106 commented May 7, 2025

Uh oh!

Uh oh!

Problem: sdk 53 is not integrated #1799

Are you sure you want to change the base?

Problem: sdk 53 is not integrated #1799

Conversation

mmsqe commented May 2, 2025

PR Checklist:

Uh oh!

coderabbitai bot commented May 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

socket-security bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JayT106 commented May 7, 2025

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented May 2, 2025 •

edited

Loading

socket-security bot commented May 2, 2025 •

edited

Loading

codecov bot commented May 2, 2025 •

edited

Loading