Problem: ibc-go v10 is not used #1804

JayT106 · 2025-05-17T02:05:02Z

Rebase #1731 with latest main which currently only integrated with ibc-go-v9

TODO: integrate with ibc-go-v10

PR Checklist:

Thank you for your code, it's appreciated! :)

Solution: - upgrade to v9 to try new features fix middleware build cleanup upgrade bump version bump deps fix middleware

align events

…feature

coderabbitai · 2025-05-17T02:05:11Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-05-17T02:06:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	golang/golang.org/x/crypto@v0.37.0
	golang/github.com/jayt106/ethermint@v0.4.2-0.20250524001118-ed40c40a9c10
	golang/google.golang.org/grpc@v1.71.1
	golang/google.golang.org/protobuf@v1.36.6
	golang/google.golang.org/genproto/googleapis/api@v0.0.0-20250106144421-5f5ef82da422
	golang/github.com/cosmos/ibc-go/v10@v10.1.1
	golang/github.com/spf13/cast@v1.7.1
	golang/github.com/cosmos/cosmos-db@v1.0.3-0.20240408151834-e75f6e4b28d8 ⏵ v1.1.1

View full report

socket-security · 2025-05-17T02:06:40Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click for details)
Warn		`golang/github.com/gofiber/fiber/[email protected]` has a Critical CVE. CVE: GHSA-98j2-3j3p-fw2v Session Middleware Token Injection Vulnerability (CRITICAL) Affected versions: < 2.52.5 Patched version: 2.52.5 From: `?` → `golang/github.com/gofiber/fiber/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore golang/github.com/gofiber/fiber/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

codecov · 2025-05-17T02:13:16Z

Codecov Report

Attention: Patch coverage is 8.64198% with 148 lines in your changes missing coverage. Please review.

Project coverage is 31.14%. Comparing base (a3c2f70) to head (87c837b).
Report is 70 commits behind head on main.

Files with missing lines	Patch %	Lines
x/cronos/middleware/conversion_middleware.go	0.00%	50 Missing ⚠️
x/cronos/events/decoders.go	0.00%	35 Missing ⚠️
x/cronos/keeper/precompiles/relayer.go	3.12%	31 Missing ⚠️
.../events/bindings/cosmos/lib/cosmos_types.abigen.go	0.00%	12 Missing ⚠️
x/cronos/keeper/keeper.go	0.00%	8 Missing ⚠️
x/cronos/keeper/precompiles/utils.go	0.00%	5 Missing ⚠️
versiondb/client/restore_app_db.go	0.00%	4 Missing ⚠️
app/upgrades.go	0.00%	1 Missing ⚠️
versiondb/client/verify.go	0.00%	1 Missing ⚠️
x/cronos/keeper/mock/ibckeeper_mock.go	91.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1804       +/-   ##
===========================================
+ Coverage   16.87%   31.14%   +14.26%     
===========================================
  Files          72      123       +51     
  Lines        6163    11672     +5509     
===========================================
+ Hits         1040     3635     +2595     
- Misses       5000     7709     +2709     
- Partials      123      328      +205

Files with missing lines	Coverage Δ
app/versiondb_placeholder.go	`0.00% <ø> (ø)`
x/cronos/client/cli/tx.go	`0.00% <ø> (-38.88%)`	⬇️
...smos/precompile/relayer/i_relayer_module.abigen.go	`0.00% <ø> (ø)`
x/cronos/events/events.go	`23.07% <ø> (ø)`
x/cronos/keeper/ibc.go	`80.43% <ø> (+80.43%)`	⬆️
x/cronos/keeper/params.go	`73.52% <100.00%> (+73.52%)`	⬆️
x/cronos/keeper/precompiles/ica.go	`14.55% <ø> (+6.96%)`	⬆️
app/upgrades.go	`0.00% <0.00%> (-5.34%)`	⬇️
versiondb/client/verify.go	`0.00% <0.00%> (ø)`
x/cronos/keeper/mock/ibckeeper_mock.go	`95.00% <91.66%> (ø)`
... and 7 more

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yihuang and others added 13 commits May 16, 2025 10:50

Problem: ibc-go v9 is not used

b5b9498

Solution: - upgrade to v9 to try new features fix middleware build cleanup upgrade bump version bump deps fix middleware

changelog

09cc3ff

remove unrelated upgrade test

47dfc5b

fix lint

0e43bcc

add light client module

ed1e020

fix relayer

077289f

align events

fix test

b56f8cf

rly grant

9c6b8eb

skip ibc_upgrade_channels

47d1398

try v10

5bb66bf

bump go

90da1e1

remove go no vendor check replacement cause fixed nixpkgs

b3c4c87

fix upgrage test failed - bump cronos binary to v1.3.4 for --dry-run …

3de3a92

…feature

JayT106 self-assigned this May 17, 2025

JayT106 requested review from yihuang, mmsqe and thomas-nguy May 17, 2025 02:05

JayT106 force-pushed the jt/ibc-go-v10 branch 2 times, most recently from cd8f46a to ea1599d Compare May 24, 2025 02:28

bump ibc-go to v10

6bb7504

JayT106 force-pushed the jt/ibc-go-v10 branch 2 times, most recently from e2fa02e to 03b2b6e Compare May 27, 2025 15:51

update proto files to support ibc-go-v10

274f904

JayT106 force-pushed the jt/ibc-go-v10 branch from 03b2b6e to 274f904 Compare May 27, 2025 15:53

JayT106 and others added 2 commits June 1, 2025 20:26

Merge branch 'main' into jt/ibc-go-v10

8399780

update HERMES to v1.13.1

fd37919

JayT106 added 4 commits June 4, 2025 17:45

fix app.ICAHostKeeper setup

ceef23c

fix icaControllerStack and ICAControllerKeeper settings

5518243

fix test_ica

9e23fc4

skip ica_incentivized test

87c837b

JayT106 force-pushed the jt/ibc-go-v10 branch from 786ce72 to 87c837b Compare June 4, 2025 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Problem: ibc-go v10 is not used #1804

Problem: ibc-go v10 is not used #1804

Uh oh!

JayT106 commented May 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 17, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

socket-security bot commented May 17, 2025 •

edited

Loading

Uh oh!

socket-security bot commented May 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Problem: ibc-go v10 is not used #1804

Are you sure you want to change the base?

Problem: ibc-go v10 is not used #1804

Uh oh!

Conversation

JayT106 commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist:

Uh oh!

coderabbitai bot commented May 17, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

socket-security bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JayT106 commented May 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented May 17, 2025 •

edited

Loading

socket-security bot commented May 17, 2025 •

edited

Loading

codecov bot commented May 17, 2025 •

edited

Loading