Skip to content

fix(testground): fix send_batch_size&send_interval setup failed in testground#1979

Open
JayT106 wants to merge 3 commits intocrypto-org-chain:mainfrom
JayT106:jt/fix-testground-benchmark-options
Open

fix(testground): fix send_batch_size&send_interval setup failed in testground#1979
JayT106 wants to merge 3 commits intocrypto-org-chain:mainfrom
JayT106:jt/fix-testground-benchmark-options

Conversation

@JayT106
Copy link
Contributor

@JayT106 JayT106 commented Feb 27, 2026

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes

    • Fixed testground setup failures related to batch size and interval configuration.
  • New Features

    • Added configurable benchmark parameters for send_batch_size and send_interval (defaults: 2000 and 0.2s).
  • Documentation

    • Updated changelog with an unreleased Bug fixes entry reflecting the setup fix.

@JayT106 JayT106 requested a review from a team as a code owner February 27, 2026 19:09
@JayT106 JayT106 requested review from calvinaco and songgaoye and removed request for a team February 27, 2026 19:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce8bdef and b396765.

📒 Files selected for processing (1)
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

Adds two configurable parameters, send_batch_size and send_interval, to the stateless testground benchmark generator and propagates them into the generated config; also adds a bug-fix entry to CHANGELOG.md documenting the fix.

Changes

Cohort / File(s) Summary
Testground generator
testground/benchmark/benchmark/stateless.py
Added send_batch_size: int = 2000 and send_interval: float = 0.2 to the _gen function signature and included both keys in the generated cfg dictionary.
Changelog
CHANGELOG.md
Added an UNRELEASED bug fixes entry noting the fix for send_batch_size & send_interval setup failures in testground.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • calvinaco

Poem

🐰 I hopped through configs bright and spry,
Two knobs I found for send and try.
Batch size set, intervals aligned,
Benchmarks hum with rhythm refined.
Hooray — the tests now pass on time!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: fixing send_batch_size and send_interval setup in testground, which directly corresponds to the actual code changes in the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.61%. Comparing base (a3c2f70) to head (b396765).
⚠️ Report is 144 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   16.87%   18.61%   +1.74%     
==========================================
  Files          72       75       +3     
  Lines        6163     5081    -1082     
==========================================
- Hits         1040      946      -94     
+ Misses       5000     4014     -986     
+ Partials      123      121       -2     

see 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant