Problem: control admin in the solidity code is not flexible#195
Problem: control admin in the solidity code is not flexible#195thomas-nguy wants to merge 1 commit intov2.0.0-cronosfrom
Conversation
533756d to
241e2f0
Compare
|
Checked the new changes on admin roles. Looks good to me. See if @brianatcrypto have any comments? |
|
Yes, I have added the whitelist guard to Whitelist are addresses that are able to relay (submit batches) but we can extend it now to also those who can deploy cosmos erc20. At anytime, the whitelist can be turned off by setting anyoneCanRelay to true I think it can add an extra security to prevent anyone to call this method (from recent bug) and since the address mapping in cronos is already permissioned, there is no use to make it public |
|
Thanks @thomas-nguy |
FinnZhangCrypto
left a comment
There was a problem hiding this comment.
Looks good to me.
Currently only the owner can pause/unpause the contract.
We want to make it more flexible so that only some special addresses can have access to those functionalities
( needed for the circuit breaker)