Bringing this up to Crystal 1.9.2 compatibility:#10
Open
akitaonrails wants to merge 4 commits into
Open
Conversation
akitaonrails
commented
Aug 31, 2023
akitaonrails
commented
- adding types for all methods and arguments
- adding 'fetch(key, &block)' feature
- adding expires_in default option to all stores that support it
- implementing expires support for the MemoryStore
- making all specs pass
- updating benchmark to pass
- adding types for all methods and arguments - adding 'fetch(key, &block)' feature - adding expires_in default option to all stores that support it - implementing expires support for the MemoryStore - making all specs pass - updating benchmark to pass
…imes it errors out as 'value has no type' and trying to force with '.as(String)' crashes the compiler. But rearranging like this make it work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.