Add #match? predicate support
#1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodywasishere
force-pushed
the
nobody/predicate-support
branch
from
5bb9efe to
8500d96
Compare
keidax
reviewed
Jan 21, 2025
| ) : Bool | ||
| unsafe_steps = LibTreeSitter.ts_query_predicates_for_pattern( | ||
| query, | ||
| capture.capture_index, |
There was a problem hiding this comment.
This is supposed to be pattern_index, not capture_index
This can and should be done in a cleaner way.
nobodywasishere
force-pushed
the
nobody/predicate-support
branch
from
8500d96 to
4de4b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predicates need to be implemented manually by the bindings as part of using the query cursor. This is one (basic) implementation that works, but it would be ideal if there was a better approach we could take that would be more general and cleaner. Open to suggestions and feedback.