Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature-request.md #10795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beta-ziliani
Copy link
Member

Adds a step to direct issuers to the forum.

Adds a step to direct issuers to the forum.
@beta-ziliani
Copy link
Member Author

Originated by #10794

@straight-shoota
Copy link
Member

Maybe we should just direct all feature requests directly to the forum? I think that might be a better workflow. Usually, they are just ideas and still need to develop into a concept. Once that's grown from an idea to a plan, a proper feature request issue can be opened, already including a detailed proposal.

@beta-ziliani
Copy link
Member Author

But at some point an issue will be issued, right? So we still need the template.

@straight-shoota
Copy link
Member

We don't need a dedicated feature template for that. It can just be a plain issue. Appropriate labels need to be applied manually anyways.

And tbh I don't see the difference between Language Improvement Discussion and Feature Request (cf.
https://forum.crystal-lang.org/t/documentation-improvement-r-in-regex/3309/2).
I would just combine them, pointing to the forum.

And add an action for creating a plain issue without labels.

@beta-ziliani
Copy link
Member Author

Sounds reasonable. Let me sleep over it.

@straight-shoota
Copy link
Member

straight-shoota commented Jun 16, 2021

Another issue I'm having with the issue templates is the automatic labeling (bug, feature). While it sounds generally nice and time-saving to add a label matching the type of issue automatically, it has two related drawbacks:

  • The label is applied based on the assessment of the issue author, not necessarily an experienced community member familiar with the taxonomy system. The label may or may not be adequate. For example: a user may perceive an unexpected behaviour as a bug, when it should actually be filed as a feature request - and vice versa.
  • If new issues don't have automatic labels, it's easy to filter the issue list for unlabeled issues to figure out which are missing an initial review from a member. I like to be able to clearly identify non-reviewed issues in order to assess them and apply appropriate additional labels.

Since we're manually adding topic, status and other labels anyways, it's not a big deal to also add kind:bug or kind:feature. I'd prefer that over automation that is possibly incorrect and actively hinders detection.

@straight-shoota
Copy link
Member

straight-shoota commented Jun 16, 2021

On a related note, Github has a somewhat unknown Triage role. It ranges between read and write access and gives permission to assign labels, mark duplicates, close and re-open discussions. So that's a moderation role.

I would like to offer this role to experienced contributors that are not core team members but can help with administrating the issue list. Or even just give them the opportunity to properly label their own issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants