ci: enable M1 runners for CI job #1127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elopez
force-pushed
the
m1-builds-github
branch
3 times, most recently
from
58f0e67 to
6a12078
Compare
Now that we have both Intel and ARM builds, we need to be able to tell them apart.
elopez
force-pushed
the
m1-builds-github
branch
from
6a12078 to
0ee721f
Compare
This was not committed with #1096 by mistake.
Member
Author
|
Action PR is here: haskell-actions/setup#47 |
M1 support has been merged upstream.
Resolved conflicts in CI workflow: - Used CACHE_VERSION v9 from master - Kept ARM64 macOS support variables (EXTRA_INCLUDE_MAC_AARCH64, EXTRA_LIB_MAC_AARCH64) - Used updated Windows cache path from master (D:\a\_temp\msys64) - Added runner.arch to cache key for architecture-specific caching
Member
|
@gustavo-grieco I tried to resolve this merge conflict as best as I could |
Collaborator
|
@elopez is our CI wizard, can you take a look to see if it makes sense merge or not? |
Member
Author
|
I'll revisit this soon, as GH is discontinuing intel runners this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables M1 (macOS aarch64) builds in our workflow.
TODO:
haskell-actions/setupupstream takes the M1 support changes