Skip to content

fix: Clean up repository by removing unused files and references #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Vivkzz
Copy link

@Vivkzz Vivkzz commented Apr 8, 2025

Hey! I'm working on issue #1354 to clean up some unused files in the repo.

I found a couple of things that could be cleaned up:

  1. There's a tstore_test.sol sitting in the root dir that's not doing much. It's just a basic test for tstore/tload ops and isn't part of our main test suite. Plus, we already have this covered with the Cancun upgrade support. No need for test files in the root!

  2. The .codeclimate.yml file isn't being used at all. Checked the CI pipeline, README, and package.yaml - nada. It's just sitting there with some basic hlint config that we're not using. The only mention of it was in CONTRIBUTING.md which was outdated.

  3. Fixed CONTRIBUTING.md by removing that outdated CodeClimate reference. We're actually using GitHub Actions, HLint, and our standard Haskell compiler warnings for code quality checks.

These changes should make the repo a bit cleaner and prevent any confusion for other contributors. Let me know if you want me to tweak anything!

@Vivkzz Vivkzz requested a review from arcz as a code owner April 8, 2025 05:05
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2025

CLA assistant check
All committers have signed the CLA.

@Vivkzz Vivkzz mentioned this pull request Apr 8, 2025
2 tasks
@elopez
Copy link
Member

elopez commented Apr 8, 2025

Hi! Thanks for the contribution! As there's already another open PR addressing this #1357 and it's a bit more comprehensive than this one, I'll be closing this to avoid duplicating efforts.

@elopez elopez closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants