Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace golang.org/x/exp with stdlib #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: replace golang.org/x/exp with stdlib #590

wants to merge 1 commit into from
+28 −33

Conversation

TechVest
Copy link

Since Go 1.21, the functions in x/exp used here can already be replaced by functions from the standard library.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

anishnaik
anishnaik approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@anishnaik anishnaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for calling this out :)

@anishnaik
Copy link
Collaborator

@TechVest do you mind merging the latest master branch? There seems to be some merge conflicts.

@TechVest
Copy link
Author

TechVest commented Apr 3, 2025

@TechVest do you mind merging the latest master branch? There seems to be some merge conflicts.

@TechVest do you mind merging the latest master branch? There seems to be some merge conflicts.

Of course. I have rebased the latest code and execute goimports.

Please review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishnaik anishnaik anishnaik approved these changes

@Xenomega Xenomega Awaiting requested review from Xenomega Xenomega is a code owner

@bsamuels453 bsamuels453 Awaiting requested review from bsamuels453 bsamuels453 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TechVest @CLAassistant @anishnaik