Attempt #2: Revamp corpus replaying #696

anishnaik · 2025-10-23T19:53:14Z

• Overview

Corrals corpus replay into the worker pool so invariant failures surface during warmup instead of after a second pass, while
keeping coverage heuristics intact.
Preserves the existing corpus format; warmup now just stages sequences for workers and reuses the current test hooks and
coverage bookkeeping.

Key Changes

fuzzing/fuzzer.go:936-952 replaces corpus replay during startup with a warmup queue: after chain setup we seed coverage
maps, enqueue all persisted sequences, and log warmup totals.
fuzzing/corpus/corpus.go:494-612 introduces PrepareForWarmup and MarkSequenceValidated, resets coverage via a lightweight
chain clone, and blocks pruning until the chooser is ready; CheckSequenceCoverageAndUpdate now returns a bool so callers can
react to coverage deltas.
fuzzing/fuzzer_worker_sequence_generator.go:16-248 tracks whether the current sequence came from warmup so workers can treat
it specially while preserving the existing mutation strategies.
fuzzing/fuzzer_worker.go:262-387 binds corpus sequences to deployed contracts, executes them through the regular test
pipeline, and re-registers successful sequences in the mutation chooser without duplicating runtime metadata.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fuzzing/corpus/corpus.go

anishnaik · 2025-10-27T18:39:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fuzzing/corpus/corpus.go

anishnaik · 2025-10-28T16:52:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fuzzing/corpus/corpus.go

anishnaik · 2025-10-28T17:01:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fuzzing/corpus/corpus.go

anishnaik · 2025-10-28T18:35:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fuzzing/corpus/corpus.go

anishnaik · 2025-10-28T18:45:59Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-10-28T18:50:53Z

fuzzing/fuzzer_worker.go

 	// Execute our call sequence.
-	_, err = calls.ExecuteCallSequenceIteratively(fw.chain, fetchElementFunc, executionCheckFunc)
+	var executedSequence calls.CallSequence
+	executedSequence, err = calls.ExecuteCallSequenceIteratively(fw.chain, fetchElementFunc, executionCheckFunc)

 	// If we encountered an error, report it.
 	if err != nil {
+		// If a corpus element fails to execute, log it (in debug mode) and exit the function early
+		if !isNewSequence {
+			fw.fuzzer.logger.Debug("[Worker ", fw.workerIndex, "] corpus element has been disabled due to an error:", err)
+			return nil, nil
+		}


Ensure worker reverts chain after failed warmup sequences

When a corpus sequence fails to execute, the error is swallowed and the function returns nil, nil, but the local err variable is left non‑nil. The deferred rollback only runs when err == nil, so the worker never calls RevertToBlockIndex in this path. A warmup failure therefore leaves the worker’s chain in a partially executed state, which can corrupt subsequent sequences and cause spurious coverage or test results. Set err = nil before returning or explicitly revert the chain before exiting so that every code path resets the chain state.

Useful? React with 👍 / 👎.

@codex this is incorrect because the defer function in testNextCallSequence will reset the chain state.

To use Codex here, create an environment for this repo.

attempt #2

89ba2ff

anishnaik requested a review from Xenomega as a code owner October 23, 2025 19:53

chatgpt-codex-connector bot reviewed Oct 23, 2025

View reviewed changes

fuzzing/corpus/corpus.go Outdated Show resolved Hide resolved

anishnaik added 4 commits October 23, 2025 16:21

fix ABI resolution issue and use in mutations issue

77fbcc8

revert changes related to mutating test result sequences

e8ca727

improve logging when initialization is complete

85cd9b0

minor tweaks

c7cf2a1

chatgpt-codex-connector bot reviewed Oct 27, 2025

View reviewed changes

fuzzing/corpus/corpus.go Show resolved Hide resolved

anishnaik added 7 commits October 27, 2025 15:14

cleaning up some comments

9f9768b

fix div by zero

88570b4

everything broke!

6943a65

fix some bugs

b47faae

remove initialize sequences function

5e49b9b

clean up and add notification system

fc40ade

final cleanup

e5e00a4

chatgpt-codex-connector bot reviewed Oct 28, 2025

View reviewed changes

fuzzing/corpus/corpus.go Show resolved Hide resolved

fix bug

f4ff8e5

chatgpt-codex-connector bot reviewed Oct 28, 2025

View reviewed changes

fuzzing/corpus/corpus.go Show resolved Hide resolved

anishnaik added 3 commits October 28, 2025 14:20

fix race condition

501fd55

only monitor for corpus initialization if corpus has elements

370176b

idk what i'm doing

17ddc8b

chatgpt-codex-connector bot reviewed Oct 28, 2025

View reviewed changes

fuzzing/corpus/corpus.go Show resolved Hide resolved

anishnaik added 2 commits October 28, 2025 14:42

bump version in dockerfile

9f0df1a

no idea what i'm doing!

93d0074

chatgpt-codex-connector bot reviewed Oct 28, 2025

View reviewed changes

anishnaik merged commit 77597e3 into master Oct 28, 2025
16 checks passed

anishnaik deleted the dev/run-corpus-across-workers branch October 28, 2025 18:59

This was referenced Oct 28, 2025

Medusa's Order of Operation results in slower iteration speed due to corpus replay #654

Closed

WIP: Update corpus initialization to immediately notify of test failures #673

Closed

Attempt #2: Revamp corpus replaying #696

Attempt #2: Revamp corpus replaying #696

Uh oh!

Conversation

anishnaik commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

anishnaik commented Oct 27, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

anishnaik commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

anishnaik commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

anishnaik commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

anishnaik commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

anishnaik Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anishnaik commented Oct 23, 2025 •

edited

Loading