Move checksum to a dedicated file #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest `foundryup` now defaults to installing stable Foundry, see foundry-rs/foundry#9585 and https://github.com/foundry-rs/foundry/releases/tag/stable Closes crytic#92
|
|
elopez
force-pushed
the
dev-foundrup-update
branch
from
d86660f to
3eef552
Compare
elopez
requested changes
Mar 21, 2025
entrypoint.sh
Outdated
| @@ -135,7 +135,8 @@ install_node() | |||
| fi | |||
|
|
|||
| wget -q -O nvm-install.sh https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | |||
| if [ ! "fabc489b39a5e9c999c7cab4d281cdbbcbad10ec2f8b9a7f7144ad701b6bfdc7 nvm-install.sh" = "$(sha256sum nvm-install.sh)" ]; then | |||
| sha256sum -c checksum --status --strict --ignore-missing | |||
There was a problem hiding this comment.
if this returns non-zero (i.e mismatched checksum), the execution will stop then because the script is run with set -e and the user won't see the error message from below.
I believe you should be able to do if ! sha256sum .....; then ... instead to have it working.
I am also not a fan of --ignore-missing, as it could be error prone. If, for instance, the filename changes, the check may still pass silently, leaving the user unprotected. We could have two separate checksum files to avoid having to use --ignore-missing
There was a problem hiding this comment.
Does this the new syntax (with the grep) look good ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is usually preferable to separate concerns. In particular, checksum are critical security values that should not be mixed up with the rest of the installation logic.
This is targetting #93