Linting and reformating done

Author: priyankabose

slither/analyses/data_dependency/data_dependency.py

@@ -292,19 +292,22 @@ def get_all_dependencies_ssa(
         return context.context[KEY_SSA_UNPROTECTED]
     return context.context[KEY_SSA]
 
+
 def get_must_depends_on(x):
     must_dependencies = compute_must_dependencies(x)
     if len(must_dependencies) > 1 or len(must_dependencies) == 0:
         return None
     return list(must_dependencies)[0]
 
+
 def compute_must_dependencies(x):
-    if isinstance(x, SolidityVariableComposed) or isinstance(x, Constant) or \
-            (x.function.visibility in ['public', 'external'] and x in x.function.parameters):
+    if isinstance(x, (SolidityVariableComposed, Constant)) or (
+        x.function.visibility in ["public", "external"] and x in x.function.parameters
+    ):
         return set([x])
 
     function_dependencies = {}
-    function_dependencies['context'] = {}
+    function_dependencies["context"] = {}
     lvalues = []
 
     for node in x.function.nodes:
@@ -322,8 +325,8 @@ def compute_must_dependencies(x):
         lvalue = lvalue_details[0]
         ir = lvalue_details[2]
 
-        if not lvalue in function_dependencies['context']:
-            function_dependencies['context'][lvalue] = set()
+        if not lvalue in function_dependencies["context"]:
+            function_dependencies["context"][lvalue] = set()
         read: Union[List[Union[LVALUE, SolidityVariableComposed]], List[SlithIRVariable]]
 
         if isinstance(ir, Index):
@@ -333,21 +336,25 @@ def compute_must_dependencies(x):
         else:
             read = ir.read
         for v in read:
-            #if not isinstance(v, Constant):
-            function_dependencies['context'][lvalue].add(v)
-    function_dependencies['context'] = convert_to_non_ssa(function_dependencies['context'])
+            # if not isinstance(v, Constant):
+            function_dependencies["context"][lvalue].add(v)
+    function_dependencies["context"] = convert_to_non_ssa(function_dependencies["context"])
 
     must_dependencies = set()
-    if x in function_dependencies['context']:
-        dependencies = list(function_dependencies['context'][x])
-        for i in range(0, len(dependencies)):
-            result = compute_must_dependencies(dependencies[i])
-            if i > 0:
-                must_dependencies = must_dependencies.intersection(result)
-            else:
-                must_dependencies = must_dependencies.union(result)
+    data_dependencies = (
+        list(function_dependencies["context"][x])
+        if function_dependencies["context"] is not None
+        else []
+    )
+    for i, data_dependency in enumerate(data_dependencies):
+        result = compute_must_dependencies(data_dependency)
+        if i > 0:
+            must_dependencies = must_dependencies.intersection(result)
+        else:
+            must_dependencies = must_dependencies.union(result)
     return must_dependencies
 
+
 # endregion
 ###################################################################################
 ###################################################################################