#2586 use enum to track variable location instead of string

[nsiregar]

No description provided.

[smonicas]

The way it's done at the moment the location value wouild still be the string that's for example why you have to use the Enum value in the comparisons. You should make the location the actual Enum when it's set which means going where set_location is called and passing the enum's variant as argument. For example myvar.set_location(VariableLocation("memory")) would set myvar's location to VariableLocation.MEMORY not "memory" the string. After that you would need to check all the places where location is used and if it's used in a comparison (like myvar.location == "memory") you need to change it to compare it against the enum variant (myvar.location == VariableLocation.MEMORY). This for both LocalVariable and StateVariable.

[dguido]

Code review

Found 2 issues:

1. Missing enum conversion in local_variable_init_from_tuple.py. When "storageLocation" in attributes, the code still passes the raw string attributes["storageLocation"] to set_location() instead of wrapping it in VariableLocation(). The else branches were correctly updated, but the if branch was missed.

slither/slither/solc_parsing/variables/local_variable_init_from_tuple.py

Lines 26 to 28 in 8bc6e07

	if "storageLocation" in attributes:
	location = attributes["storageLocation"]
	self.underlying_variable.set_location(location)

Fix: Change to location = VariableLocation(attributes["storageLocation"])

2. Missing enum conversion in state_variable.py. Same issue - the if "storageLocation" in attributes: branch passes raw string instead of VariableLocation(attributes["storageLocation"]). The else branch was correctly updated to use VariableLocation.DEFAULT.

slither/slither/solc_parsing/variables/state_variable.py

Lines 23 to 24 in 8bc6e07

	if "storageLocation" in attributes:
	self.underlying_variable.set_location(attributes["storageLocation"])

Fix: Change to self.underlying_variable.set_location(VariableLocation(attributes["storageLocation"]))

Note: The correct pattern is shown in local_variable.py which properly wraps the string in VariableLocation(). These type mismatches would cause runtime issues when parsing contracts with explicit storage location keywords.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}