fix: expand add_refers_to assertion to accept TopLevelVariable #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add_refers_to method in LocalIRVariable was failing with an AssertionError during SSA generation when the rvalue was a TopLevelVariable (file-level constant/immutable). This fix expands the assertion to accept TopLevelVariable in addition to the existing SlithIRVariable and TemporaryVariable types.
nisedo
force-pushed
the
fix/ssa-add-refers-to-assertion
branch
from
b962ec1 to
f5056e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
add_refers_tomethod inLocalIRVariablewas failing with anAssertionErrorduring SSA generation when the rvalue was aTopLevelVariable(file-level constant/immutable).This fix expands the assertion to accept
TopLevelVariablein addition to the existingSlithIRVariableandTemporaryVariabletypes.Details
Root cause: When analyzing contracts that reference file-level constants/immutables in storage pointer contexts, the SSA generation passes a
TopLevelVariabletoadd_refers_to, which only acceptedSlithIRVariableandTemporaryVariable.Similar precedent: PR Fixed issue which disallowed using operator[] with TopLevelVariables #1968 fixed a similar issue where
TopLevelVariablewasn't supported in other slithir operations (index.py,reference.py).