Fix call-graph printer to distinguish overloaded functions #2909
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #664
The call-graph printer was using just
function.namefor node IDs and labels, causing overloaded functions (same name, different signatures) to appear as the same node. This made it look like functions were calling themselves when they were actually calling an overloaded variant.Problem
For the SafeMath library example in the issue:
The graph showed
sub→sub, making it look like a self-call.Solution
function.full_name(includes parameter types) for node IDs to ensure each overloaded function gets a unique nodefunction.full_namefor labels so users can distinguish between overloaded functions in the graphfunction.solidity_signaturefor Variables (public state variables) to maintain consistencyBefore/After
Before:
After:
Test Plan
🤖 Generated with Claude Code