Skip to content

fix: exclude interfaces in inheritance-graph edges #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajatbeladiya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: exclude interfaces in inheritance-graph edges #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slither/printers/inheritance/inheritance_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ def _summary(self, contract):
]

# Add arrows (number them if there is more than one path so we know order of declaration for inheritance).
# Note: `inheritance` is already filtered to exclude mocks and (by default) interfaces.
if len(inheritance) == 1:
immediate_inheritance = contract.immediate_inheritance[0]
immediate_inheritance = inheritance[0]
ret += f"c{contract.id}_{contract.name} -> c{immediate_inheritance.id}_{immediate_inheritance};\n"
else:
for i, immediate_inheritance in enumerate(inheritance):
Expand Down
11 changes: 11 additions & 0 deletions tests/e2e/printers/test_data/test_contract_names/D.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import "./A.sol";

interface MyInterfaceY {
function ping() external;
}

// Intentionally list the interface first to ensure the inheritance-graph printer
// respects the interface filtering logic (see issue #2150).
contract D is MyInterfaceY, A {
function ping() external override {}
}
2 changes: 2 additions & 0 deletions tests/e2e/printers/test_printers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def test_inheritance_graph_printer(solc_binary_path) -> None:
standard_json.add_source_file(Path(TEST_DATA_DIR, "test_contract_names", "B.sol").as_posix())
standard_json.add_source_file(Path(TEST_DATA_DIR, "test_contract_names", "B2.sol").as_posix())
standard_json.add_source_file(Path(TEST_DATA_DIR, "test_contract_names", "C.sol").as_posix())
standard_json.add_source_file(Path(TEST_DATA_DIR, "test_contract_names", "D.sol").as_posix())
compilation = CryticCompile(standard_json, solc=solc_path)
slither = Slither(compilation)
printer = PrinterInheritanceGraph(slither=slither, logger=None)
Expand All @@ -44,6 +45,7 @@ def test_inheritance_graph_printer(solc_binary_path) -> None:

assert counter["B -> A"] == 2
assert counter["C -> A"] == 1
assert counter["D -> A"] == 1
# Let also test the include/exclude interface behavior
# Check that the interface is not included
assert "MyInterfaceX" not in content
Expand Down