a1-nickborrello #72
a1-nickborrello #72
Conversation
There was a problem hiding this comment.
Pull request overview
This PR represents a student's submission for Assignment 1 in CS 4241 (Webware), where a template website is personalized with student information and styled with custom CSS. The submission includes personal details, course background, technology experience, and implements several design achievements including a custom color palette and Google Fonts integration.
Key Changes:
- Personalized HTML content with student information (Nicholas Borrello, Class of 2024)
- Added embedded CSS styling with custom color palette and animations
- Added server routes for serving image files
- Simplified README to a basic project description
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| server.js | Added route handlers for two image files (IMG_1492.jpeg and WPI_logo.svg.png) |
| index.html | Complete personalization with student info, embedded CSS styling, header/footer elements, and semantic HTML structure |
| colorPallete.png | New image file containing the color palette used in the design |
| WPI_logo.svg.png | New image file (appears unused in the HTML) |
| README.md | Replaced assignment instructions with brief project description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <body> | ||
| <h1>Information about [Your name here]</h1> | ||
| <h1>Information about Nicholas Borrello</h1> | ||
| <img src="https://cdn.glitch.global/0c95c592-3144-4970-a887-234aa55efd2b/IMG_1492.jpeg?v=1693489897625" alt="My Dog :)" width="100"> |
There was a problem hiding this comment.
The image alt text "My Dog :)" lacks descriptive information. For better accessibility, provide a more descriptive alt text such as "Photo of my dog" or "Portrait of [dog's name]". Alt text should describe the image content for users who cannot see the image.
| <img src="https://cdn.glitch.global/0c95c592-3144-4970-a887-234aa55efd2b/IMG_1492.jpeg?v=1693489897625" alt="My Dog :)" width="100"> | |
| <img src="https://cdn.glitch.global/0c95c592-3144-4970-a887-234aa55efd2b/IMG_1492.jpeg?v=1693489897625" alt="Photo of my dog" width="100"> |
| case '/IMG_1492.jpeg': | ||
| sendFile( response, 'IMG_1492.jpeg') | ||
| break | ||
| case 'WPI_logo.svg.png': |
There was a problem hiding this comment.
Missing leading forward slash in the case statement. The route should be '/WPI_logo.svg.png' instead of 'WPI_logo.svg.png'. Without the leading slash, this route will never match incoming requests, making the file inaccessible.
| case 'WPI_logo.svg.png': | |
| case '/WPI_logo.svg.png': |
| <hn align="center"> | ||
| <h3> | ||
| - Assignment 1 - Hello World: Basic Deployment w/ Git, GitHub, Glitch | ||
| </h3> | ||
| </hn> |
There was a problem hiding this comment.
<hn> is not a valid HTML tag. Based on the context, this should likely be <div> or removed entirely since the <h3> tag inside already provides the heading structure. The align attribute on this invalid tag is also deprecated - use CSS for alignment instead (e.g., text-align: center).
| <hn align="center"> | ||
| <h3> | ||
| 8/31/2023 | ||
| </h3> | ||
| </hn> |
There was a problem hiding this comment.
<hn> is not a valid HTML tag. Based on the context, this should likely be <div> or removed entirely since the <h3> tag inside already provides the heading structure. The align attribute on this invalid tag is also deprecated - use CSS for alignment instead (e.g., text-align: center).
| <header> | ||
| <hn align="center"> | ||
| <h3> | ||
| - Assignment 1 - Hello World: Basic Deployment w/ Git, GitHub, Glitch | ||
| </h3> | ||
| </hn> | ||
| </header> |
There was a problem hiding this comment.
The <header> and <footer> elements are placed outside the <body> tag. In valid HTML5, these semantic elements should be inside the <body> tag. Move lines 47-53 and 95-101 inside the <body> element.
| </body> | ||
| <footer> | ||
| <hn align="center"> | ||
| <h3> | ||
| 8/31/2023 | ||
| </h3> | ||
| </hn> | ||
| </footer> |
There was a problem hiding this comment.
The <footer> element is placed outside the <body> tag. In valid HTML5, the footer should be inside the <body> tag. Move lines 95-101 inside the <body> element, before the closing </body> tag.
| </body> | |
| <footer> | |
| <hn align="center"> | |
| <h3> | |
| 8/31/2023 | |
| </h3> | |
| </hn> | |
| </footer> | |
| <footer> | |
| <hn align="center"> | |
| <h3> | |
| 8/31/2023 | |
| </h3> | |
| </hn> | |
| </footer> | |
| </body> |
1 participant
No description provided.