RequestShare: Introduce the notion of a share request #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micke Nordin <[email protected]>
| Consumer specific identifier of the user, group or federation that | ||
| wants to recive a share of the resource. | ||
| example: [email protected] | ||
| shareId: |
There was a problem hiding this comment.
Is this the same as providerId in NewShare ?
| * using `application/json` as the `Content-Type` HTTP request header | ||
| * its request body containing a JSON document representing an object with the fields as described below | ||
| * using TLS | ||
| * using [httpsig](https://datatracker.ietf.org/doc/html/draft-cavage-http-signatures-12) |
There was a problem hiding this comment.
I guess that should be httpsig [RFC9421]
glpatcern
requested changes
Aug 22, 2025
| Consumer specific identifier of the user, group or federation that | ||
| wants to recive a share of the resource. | ||
| Example: "[email protected]" | ||
| * REQUIRED shareId (string) |
There was a problem hiding this comment.
Here we have a problem: a receiver won't know the (opaque) ID of a remote resource, but only a path (or something "human readable"?). Shall we name this simply share, or sharePath?
| A unique identifier for the resource. | ||
| Example: 1234567890abcdef | ||
|
|
||
| After receiving a request for a Share, the Sending Party MAY send a Share Creation Notification to the Sending Party using the OCM address in the shareWith field. |
There was a problem hiding this comment.
Here I'd imagine the flow to be async: the server would respond HTTP 202 Accepted, signifying that the sender user was notified about the request to share. Once they accept, the normal Share Notification will take place.
Co-authored-by: Giuseppe Lo Presti <[email protected]>
Co-authored-by: Giuseppe Lo Presti <[email protected]>
Co-authored-by: Giuseppe Lo Presti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.