a3-Michael-Lai #107
Open
a3-Michael-Lai #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A3 (again)
|
Also, there was an original issue with the Github OAuth client secret being public, but that's already been patched in the main branch and I just created a new client secret (and deleted the old one). |
|
A very small security fix to the project. Forgot to obfuscate the username and password to the MongoDB database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://a3-michael-lai.herokuapp.com/
Note: Professor gave me a 24 hr extension.
Well then, this project went better than the last. There are two things I wasn't able to fully implement:
Instead of panic commiting a late fix like last time, I'll probably make a branch and see what I could do. Heroku definitely would help, as I can easily deploy between two branches. If I finalize a fix, I'll make a comment on it and post a link to the branch. It would be up to you if you want to consider those fixes (but the original submission would remain intact in the main branch).