Increase CI test timeouts to improve MySQL backend test reliability - #421
Merged
Conversation
- Set WorkflowLockTimeout to 5 seconds for MySQL tests (down from 1 minute) - Set ActivityLockTimeout to 10 seconds for MySQL tests (down from 2 minutes) - Added time import to mysql_test.go for duration constants - Applies to both Test_MysqlBackend and TestMySqlBackendE2E functions Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Frequent test timeouts in CI for mysql backend
Fix MySQL backend test timeouts by reducing lock timeouts in test configuration
Aug 20, 2025
Owner
|
@copilot Also increase the test timeout in the workflow file. Right now it's |
Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Fix MySQL backend test timeouts by reducing lock timeouts in test configuration
Fix MySQL backend test timeouts by reducing lock timeouts and increasing CI timeout limits
Aug 20, 2025
cschleiden
reviewed
Aug 20, 2025
Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
Copilot
AI
changed the title
Fix MySQL backend test timeouts by reducing lock timeouts and increasing CI timeout limits
Increase CI test timeouts to improve MySQL backend test reliability
Aug 20, 2025
cschleiden
marked this pull request as ready for review
August 20, 2025 22:24
cschleiden
enabled auto-merge (squash)
August 20, 2025 22:25
cschleiden
disabled auto-merge
August 20, 2025 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MySQL backend tests were frequently timing out in CI due to tests running very close to the 120-second CI timeout limit.
Problem
MySQL backend tests could easily exceed the CI timeout when dealing with lock contention or waiting for locks to expire, causing frequent test failures like:
Solution
Increased CI test timeouts in
.github/workflows/go.ymlfrom 120s to 240s for all test jobs to provide additional safety buffer for MySQL backend tests and other potentially long-running tests.Results
The fix addresses the timeout issue by providing more generous CI limits while maintaining all original test behavior and production settings.
Fixes #420.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.