Fix waitGroup.Wait() blocking forever when Add is never called - #474
Merged
Conversation
When Wait() is called without any prior Add(), the counter is already 0 but the internal future was never resolved, causing Wait() to block indefinitely. Return early from Wait() when the counter is 0. Fixes #472 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cschleiden
force-pushed
the
claude/competent-diffie
branch
from
March 23, 2026 05:11
793e098 to
ed92f86
Compare
cschleiden
enabled auto-merge (rebase)
March 23, 2026 05:11
cschleiden
disabled auto-merge
March 23, 2026 05:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitGroup.Wait()blocks indefinitely ifAdd()was never called, because the internal future is never resolvedWait()when the counter is already 0Wait()withoutAdd()caseFixes #472
Test plan
Test_WaitGroup_WaitWithoutAddpasses🤖 Generated with Claude Code