Skip to content

Guard HMGET against empty payload keys in GetWorkflowInstanceHistory #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cschleiden merged 3 commits into from
Aug 10, 2026
Merged

Guard HMGET against empty payload keys in GetWorkflowInstanceHistory #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3737a8
Guard HMGET against empty payload keys in GetWorkflowInstanceHistory
DerkSchooltink Jul 2, 2026
e56e2fc
Merge branch 'main' into fix/hmget-empty-payloads
DerkSchooltink Jul 21, 2026
70506c3
Add empty workflow history regression test
cschleiden Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions backend/redis/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,17 @@ func (rb *redisBackend) GetWorkflowInstanceHistory(ctx context.Context, instance
events = append(events, event)
}

res, err := rb.rdb.HMGet(ctx, rb.keys.payloadKey(instance), payloadKeys...).Result()
if err != nil {
return nil, fmt.Errorf("reading payloads: %w", err)
}

for i, event := range events {
event.Attributes, err = history.DeserializeAttributes(event.Type, []byte(res[i].(string)))
if len(payloadKeys) > 0 {
res, err := rb.rdb.HMGet(ctx, rb.keys.payloadKey(instance), payloadKeys...).Result()
if err != nil {
return nil, fmt.Errorf("deserializing attributes for event %v: %w", event.Type, err)
return nil, fmt.Errorf("reading payloads: %w", err)
}

for i, event := range events {
event.Attributes, err = history.DeserializeAttributes(event.Type, []byte(res[i].(string)))
if err != nil {
return nil, fmt.Errorf("deserializing attributes for event %v: %w", event.Type, err)
}
}
}

Expand Down
11 changes: 11 additions & 0 deletions backend/test/backendtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,17 @@ func BackendTest(t *testing.T, setup func(options ...backend.BackendOption) Test
require.Error(t, err)
},
},
{
name: "GetWorkflowInstanceHistory_ReturnsEmptyHistory",
f: func(t *testing.T, ctx context.Context, b backend.Backend) {
instance := core.NewWorkflowInstance(uuid.NewString(), uuid.NewString())

events, err := b.GetWorkflowInstanceHistory(ctx, instance, nil)

require.NoError(t, err)
require.Empty(t, events)
},
},
{
name: "CompleteWorkflowTask_AddsNewEventsToHistory",
f: func(t *testing.T, ctx context.Context, b backend.Backend) {
Expand Down
Loading