Skip to content
This repository was archived by the owner on Feb 25, 2022. It is now read-only.

Add tests to Redirection Example #335

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lyokone
Copy link

@Lyokone Lyokone commented Jan 27, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Add tests to Redirection Example and Mockito for creating a MockGoRouter

⤵️ What is the current behavior?

No tests

🆕 What is the new behavior (if this is a feature change)?

Test the redirection example

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Run in example folder

flutter test --no-pub --coverage --test-randomize-ordering-seed random

To generate coverage. You can use LCOV to see the coverage of the example app.
The redirection.dart is at 95.8% of Coverage with this PR.

📝 Links to relevant issues/docs

Not sure if I should update changelog since it's only testing the examples.

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated the relevant documentation.
  • I updated the relevant code example.
  • I rebased onto current master.

@csells
Copy link
Owner

csells commented Feb 10, 2022

@Lyokone can you fix the style issue and resubmit? Likely dart format . will solve the problem.

@Lyokone
Copy link
Author

Lyokone commented Feb 15, 2022

It should be fixed now :)

@csells
Copy link
Owner

csells commented Feb 19, 2022

@chunhtai @Lyokone This PR is something to land after the PR bring go_router to flutter/packages has landed.

@Lyokone
Copy link
Author

Lyokone commented Feb 19, 2022

I can definitely resubmit this PR to flutter/package if needed 😊

@chunhtai
Copy link

@Lyokone yes please do. we are trying to bring the package into the flutter/package within this week.

@chunhtai
Copy link

this package has been moved to https://github.com/flutter/packages/tree/main/packages/go_router

Can you create a pull request against the flutter/packages instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants