Added magnitudes as init attribute for CartesianGrid2D class#273
Merged
Serra314 merged 1 commit intocseptesting:mainfrom Apr 7, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new optional "magnitudes" attribute to the CartesianGrid2D class and updates related instantiations across the code to use this parameter instead of assigning it after initialization. Key changes include:
- Updating the CartesianGrid2D constructor to accept an optional magnitudes parameter.
- Modifying region-builder functions in csep/core/regions.py to pass magnitudes directly.
- Adjusting unit tests in tests/test_spatial.py to include a magnitudes array during grid instantiation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_spatial.py | Updated grid instantiation to include magnitudes in unit tests |
| csep/core/regions.py | Refactored region creation functions to pass magnitudes |
…faults to none. Changed default CSEP regions instantiation to account for this, instead of hardcoding magnitudes. tests: added magnitude instantiation in class unit tests.
bee4da4 to
15ad8df
Compare
Serra314
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The magnitude attribute it is now an argument of the CartesianRegion2D class, and not left to the user to hardcode it after class instantiation. It is optional (defaults to None), in case the region is used exclusively in the spatial sense.
fix: Added magnitudes as init attribute for CartesianGrid2D class. Defaults to none. Changed default CSEP regions instantiation to account for this, instead of hardcoding magnitudes.
tests: added magnitude instantiation in class unit tests.
closes #257
pyCSEP Pull Request Checklist
Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.
Fixes issue #(please fill in or delete if not needed).
Type of change:
Please delete options that are not relevant.
Checklist: