[pull] master from paritytech:master #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key Points :
1. Flow: User calls set_keys on AH → AH validates keys/proof → AH sends
XCM to RC → RC calls set_keys_from_ah → RC sets keys via
SessionInterface
2. Fee model: Total fee = delivery fee + execution cost, all charged on
AH upfront; RC uses UnpaidExecution
3. Validation split:
- AH validates keys format and ownership proof (prevents XCM queue
bloating)
- RC trusts AH's validation and just stores the keys
4. Access control:
- set_keys: Requires caller to be a registered validator
- purge_keys: Anyone can call (allows chilled validators to purge keys)
Notes:
- Staking proxies can call `set_keys` and `purge_keys` on behalf of
validators. The `ProxyType::Staking` filter on runtime has been updated
to include these calls.
- Validators are still allowed to call `set_keys` and `purge_keys` via
relay-chain pallet-session's extrinsics. This option will be deprecated
in the future.
- No key deposit is required on AssetHub.
- **Workflow Change**: unlike the current flow for new validators on RC
`(bond -> set_keys -> validate)`, users on Asset Hub MUST call bond and
validate BEFORE calling set_keys. Attempting to set keys before
declaring intent to validate will fail with NotValidator.
Close #8806.
---------
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankan <[email protected]>
This PR fixes a minor discrepancy in the Snowbridge Ethereum cient pallet where the fork version for sync committee signature verification was derived from `signature_slot` instead of `signature_slot - 1` as required by the https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/sync-protocol.md#validate_light_client_update. This caused valid light client updates to be rejected at Ethereum hard-fork boundaries. The impact is low severity - only affecting liveness once or twice a year for a few minutes. Origin: bug bounty report. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )