[pull] master from paritytech:master #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a **Geth-compatible execution tracer** ([StructLogger](https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers#struct-opcode-logger)) for pallet-revive The tracer can be used to capture both EVM opcode and PVM syscall. It can be used with the same RPC endpoint as Geth StructLogger. Since it can be quite resource intensive, It can only be queried from the node when the **DebugSettings** are enabled (This is turned on now by default in the dev-node) Tested in paritytech/evm-test-suite#138 example: ```sh ❯ cast rpc debug_traceTransaction "<TX_HASH>" | jq # or with options # See list of options https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers#struct-opcode-logger ❯ cast rpc debug_traceTransaction "<TX_HASH>", { "tracer": { "enableMemory": true } } | jq ``` The response includes additional fields compared to the original Geth debug RPC endpoints: For the trace: - `weight_consumed`: same as gas but expressed in Weight - `base_call_weight`: the base cost of the transaction For each step: - `weight_cost`: same as gas_cost but expressed in Weight For an EVM execution, the output will look like this ```json { "gas": 4208049, "weight_consumed": { "ref_time": 126241470000, "proof_size": 4208 }, "base_call_weight": { "ref_time": 9000000000, "proof_size": 3000 }, "failed": false, "returnValue": "0x", "structLogs": [ { "gas": 4109533, "gasCost": 3, "weight_cost": { "ref_time": 90000, "proof_size": 0 }, "depth": 1, "pc": 0, "op": "PUSH1", "stack": [] }, { "gas": 4109530, "gasCost": 3, "weight_cost": { "ref_time": 90000, "proof_size": 0 }, "depth": 1, "pc": 2, "op": "PUSH1", "stack": [ "0x80" ] }, { "gas": 4109527, "gasCost": 3, "weight_cost": { "ref_time": 90000, "proof_size": 0 }, "depth": 1, "pc": 4, "op": "MSTORE", "stack": [ "0x80", "0x40" ] }] } ``` For PVM execution, each step includes additional fields not present in Geth: - `args`: Array of syscall arguments (register values a0-a5) as hex strings - `returned`: The syscall return value as hex string These fields are enabled by default. To disable them, use `disableSyscallDetails: true`. Example output with syscall details: ```json { "gas": 97108, "gasCost": 131, "weight_cost": { "ref_time": 3930000, "proof_size": 0 }, "depth": 1, "op": "call_data_load", "args": ["0x0", "0x4"], "returned": "0x2a" } ``` --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xermicus <[email protected]>
This PR spawns the network backends as essential (libp2p / litep2p). When the network future exits, it will bring down the whole process. - there's no point in running a node without the core network backend as it will not be able to communicate with peers - while at it, have changed some logs from debug to warn - the network backend can be brought down unintentionally by the `import_notif_stream` Discovered during: - #10821 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )